build: publish script should not print error if tag does not exist #15080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the publish script prints an error if the release tag does not exist locally yet. This is not expected since the function that calls `git` to check if a given tag exists, returns a boolean and should not additionally print the git `stderr`.
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
jelbourn
reviewed
Feb 4, 2019
devversion
force-pushed
the
build/release-script-improvements
branch
from
28f3d1e to
dcf1d9e
Compare
Currently when the publish script completes, the caretaker still needs to draft the release online in the GitHub UI. In order to make this easier for the caretaker, we generate an URL that automatically fills in the proper release tag and the release name. Note we can also look into attaching the release notes automatically, but since the release notes are making the URL too large and Github denies too large URL's, this is something we can explore in a follow-ups.
devversion
force-pushed
the
build/release-script-improvements
branch
from
dcf1d9e to
c2fb413
Compare
jelbourn
pushed a commit
that referenced
this pull request
Feb 11, 2019
…15080) Currently the publish script prints an error if the release tag does not exist locally yet. This is not expected since the function that calls `git` to check if a given tag exists, returns a boolean and should not additionally print the git `stderr`. Note we can also look into attaching the release notes automatically, but since the release notes are making the URL too large and Github denies too large URL's, this is something we can explore in a follow-ups.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the publish script prints an error if the release tag does not exist locally yet. This is not expected since the function that calls
gitto check if a given tag exists, returns a boolean and should not additionally print the gitstderr.