Skip to content

fix(docs): telephone number input control example is missing programa… #15130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 25, 2019
Merged

fix(docs): telephone number input control example is missing programa… #15130

merged 2 commits into from
Feb 25, 2019

Conversation

Suresh918
Copy link
Contributor

@Suresh918 Suresh918 commented Feb 8, 2019 •
edited
Loading

Fixes #15024

@Suresh918 Suresh918 requested a review from jelbourn as a code owner February 8, 2019 17:31
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 8, 2019
crisbeto
crisbeto reviewed Feb 10, 2019
View reviewed changes
src/material-examples/form-field-custom-control/example-tel-input-example.html Outdated
@@ -1,7 +1,7 @@
<div [formGroup]="parts" class="example-tel-input-container">
<input class="example-tel-input-element" formControlName="area" size="3">
<input class="example-tel-input-element" formControlName="area" size="3" aria-label="Enter first 3 digits of phone number">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The label should be "Area code".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed as per your suggestion. Can you please check now.

src/material-examples/form-field-custom-control/example-tel-input-example.html Outdated
<span class="example-tel-input-spacer">&ndash;</span>
<input class="example-tel-input-element" formControlName="exchange" size="3">
<input class="example-tel-input-element" formControlName="exchange" size="3" aria-label="Enter middle 3 digits of phone number">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The label should be "Exchange code".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed as per your suggestion. Can you please check now

src/material-examples/form-field-custom-control/example-tel-input-example.html Outdated
<span class="example-tel-input-spacer">&ndash;</span>
<input class="example-tel-input-element" formControlName="subscriber" size="4">
<input class="example-tel-input-element" formControlName="subscriber" size="4" aria-label="Enter last 4 digits of phone number">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The label should be "Subscriber number".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed as per your suggestion. Can you please check now

jelbourn
jelbourn approved these changes Feb 19, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm Accessibility This issue is related to accessibility (a11y) docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Feb 19, 2019
@jelbourn
Copy link
Member

@Suresh918 can you rebase this PR?

@Suresh918 Suresh918 force-pushed the form-field-custom-telephone-control branch from bc2252c to bc21abc Compare February 25, 2019 16:18
@Suresh918
Copy link
Contributor Author

@jelbourn Rebased the pull request

@jelbourn jelbourn merged commit 6f3c2de into angular:master Feb 25, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto left review comments

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

telephone number input control example is missing programatic labels
4 participants
@Suresh918 @jelbourn @crisbeto @googlebot