Skip to content

build: publish script should should note where to paste changelog #15218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tools/release/git/github-urls.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@ export function getGithubBranchCommitsUrl(owner: string, repository: string, bra

/** Gets a Github URL that can be used to create a new release from a given tag. */
export function getGithubNewReleaseUrl(options: {owner: string, repository: string,
tagName: string, releaseTitle: string}) {
tagName: string, releaseTitle: string, body: string}) {

return `https://github.com/${options.owner}/${options.repository}/releases/new?` +
`tag=${encodeURIComponent(options.tagName)}&` +
`title=${encodeURIComponent(options.releaseTitle)}&`;
`title=${encodeURIComponent(options.releaseTitle)}&` +
`body=${encodeURIComponent(options.body)}`;
}
10 changes: 8 additions & 2 deletions tools/release/publish-release.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,15 +126,21 @@ class PublishReleaseTask extends BaseReleaseTask {
repository: this.repositoryName,
tagName: newVersionName,
releaseTitle: releaseTitle,
// TODO: we cannot insert the real changelog here since the URL would become
// way too large and Github would consider this as a malformed page request.
body: 'Copy-paste changelog in here!'
});

console.log();
console.info(green(bold(` ✓ Published all packages successfully`)));

// Always log out of npm after releasing to prevent unintentional changes to
// any packages.
npmLogout();
console.info(green(bold(` ✓ Logged out of npm`)));
if (npmLogout()) {
console.info(green(` ✓ Logged out of npm`));
} else {
console.error(red(` ✘ Could not log out of NPM. Please manually log out!`));
}

console.info(yellow(` ⚠ Please draft a new release of the version on Github.`));
console.info(yellow(` ${newReleaseUrl}`));
Expand Down