fix(schematics): incorrectly throws if NgModule uses namespaced decorator #15298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ator Currently if the developer defines the primary app `NgModule` using a namespaced import (e.g. "@ngCore.NgModule`), the Material schematics will incorrectly not detect that module as the logic that resolves the decorator name of a class declaration is flawed. This is because it incorrectly traverses a `PropertyAccessExpression`, while the accessed property name is exposed at the root level `PropertyAccessExpression`. This commit fixes this and also adds additional unit tests for the `hasNgModuleImport` utility function. (We have integration tests for this; but we don't test that special case)
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
josephperrott
pushed a commit
that referenced
this pull request
Mar 4, 2019
…ator (#15298) Currently if the developer defines the primary app `NgModule` using a namespaced import (e.g. "@ngCore.NgModule`), the Material schematics will incorrectly not detect that module as the logic that resolves the decorator name of a class declaration is flawed. This is because it incorrectly traverses a `PropertyAccessExpression`, while the accessed property name is exposed at the root level `PropertyAccessExpression`. This commit fixes this and also adds additional unit tests for the `hasNgModuleImport` utility function. (We have integration tests for this; but we don't test that special case)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the developer defines the primary app
NgModuleusing a namespacedimport (e.g.
@ngCore.NgModule), the Material schematics will incorrectly not detectthat module as the logic that resolves the decorator name of a class declaration
is flawed.
This is because it incorrectly traverses a
PropertyAccessExpression, while theaccessed property name is exposed at the root level
PropertyAccessExpression.This PR fixes this and also adds additional unit tests for the
hasNgModuleImportutility function. (We have integration tests for this; but we don't test that special case)