Skip to content

docs(drag-drop): add docs and live example for delay input #15370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 2, 2019

Adds some docs and a live example for the cdkDragStartDelay input. Follow-up from #14732.

Note: targeting major, because the PR that introduces the functionality was merged into the next major branch.

@crisbeto crisbeto added docs This issue is related to documentation pr: merge safe target: major This PR is targeted for the next major release labels Mar 2, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner March 2, 2019 18:59
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 2, 2019
Adds some docs and a live example for the `cdkDragStartDelay` input. Follow-up from angular#14732.
@crisbeto crisbeto force-pushed the drag-drop-delay-example branch from 9a741ec to 6470b0a Compare March 13, 2019 23:07
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Apr 2, 2019
@ngbot
Copy link

ngbot bot commented Apr 2, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: build_devapp_aot" is failing
    failure status "ci/circleci: prerender_build" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba mmalerba merged commit fe56952 into angular:master Apr 2, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants