refactor(drag-drop): remove manual observers count #15441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
reviewed
Mar 12, 2019
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Mar 12, 2019
Uses the observer count from the `Subject` itself, rather than counting it manually. Relates to angular#15441.
|
Hi @crisbeto, I've updated the PR with the changes you asked. Ready for review. |
|
Sorry for the delay @vitaliy-bobrov, I must've missed the notification. It seems like the CI is failing. You should be able to fix it by running |
|
@crisbeto, Done, now all checks on CI pass. Ready for review |
crisbeto
added
pr: lgtm
action: merge
jelbourn
pushed a commit
that referenced
this pull request
May 13, 2019
Uses the observer count from the `Subject` itself, rather than counting it manually. Relates to #15441.
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
Uses the observer count from the `Subject` itself, rather than counting it manually. Relates to angular#15441.
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved event for drag-drop uses manual observers count to prevent emitting when no observers. RxJS Subject already counts it for us, we can check
Subject.observers.lengthproperty - https://rxjs.dev/api/index/class/Subject#properties