Skip to content

fix(stepper): avoid breaking change in stepControl type #15464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2019

Conversation

crisbeto
Copy link
Member

In #15134 we reworked the stepper not to depend on @angular/forms under the assumption that our limited FormControl interface would be enough to avoid a breaking change. Some people ended up being broken by the change so this PR reworks the stepControl type to avoid the breaking change.

Fixes #15462.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Mar 13, 2019
@crisbeto crisbeto requested a review from mmalerba as a code owner March 13, 2019 18:13
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 13, 2019
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 13, 2019
@ngbot
Copy link

ngbot bot commented Mar 13, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: api_golden_checks" is failing
    pending status "ci/circleci: tests_browserstack" is pending
    pending status "ci/circleci: tests_local_browsers" is pending
    pending status "ci/circleci: tests_saucelabs" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

In angular#15134 we reworked the stepper not to depend on `@angular/forms` under the assumption that our limited `FormControl` interface would be enough to avoid a breaking change. Some people ended up being broken by the change so this PR reworks the `stepControl` type to avoid the breaking change.

Fixes angular#15462.
@crisbeto crisbeto force-pushed the 15462/stepper-breaking-change branch from ba77f73 to d16d8cf Compare March 13, 2019 18:19
@mmalerba mmalerba merged commit a146499 into angular:master Mar 13, 2019
mmalerba pushed a commit that referenced this pull request Mar 18, 2019
In #15134 we reworked the stepper not to depend on `@angular/forms` under the assumption that our limited `FormControl` interface would be enough to avoid a breaking change. Some people ended up being broken by the change so this PR reworks the `stepControl` type to avoid the breaking change.

Fixes #15462.
@biltongza
Copy link

biltongza commented Apr 12, 2019

This is still a breaking change for us since FormControlLike is not exported. We depended on this being AbstractControl in one of our methods to mark all child controls as touched, and now the only option we really have is to cast the FormControlLike to AbstractControl. Is that the recommended option?

Suresh918 pushed a commit to Suresh918/material2 that referenced this pull request Apr 15, 2019
In angular#15134 we reworked the stepper not to depend on `@angular/forms` under the assumption that our limited `FormControl` interface would be enough to avoid a breaking change. Some people ended up being broken by the change so this PR reworks the `stepControl` type to avoid the breaking change.

Fixes angular#15462.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7.3.4 is not a patch
4 participants