Skip to content

build: staging script should ignore pre-commit hook #15612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2019
Merged

build: staging script should ignore pre-commit hook #15612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tools/release/git/git-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ export class GitClient {

/** Creates a new commit within the current branch with the given commit message. */
createNewCommit(message: string): boolean {
return this._spawnGitProcess(['commit', '-m', message]).status === 0;
// Disable pre-commit hooks when creating a commit. Developers might not have set up
// their Git configuration for the "git-clang-format" pre-commit hook.
return this._spawnGitProcess(['commit', '--no-verify', '-m', message]).status === 0;
}

/** Gets the title of a specified commit reference. */
Expand Down