Skip to content

build: add circleci fallback caching #15625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

Enables fallback caching within CircleCI. This means that all PRs or jobs
that caused a change in the cache key still run with the most recent and
closest maching cache. Meaning that we in theory never need to pull
Bazel repositories or node_modules from scratch (unless we explicitly
want to purge the cache).

Same has been applied to angular/angular as well.

@devversion devversion requested a review from jelbourn as a code owner March 27, 2019 13:46
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 27, 2019
Enables fallback caching within CircleCI. This means that all PRs or jobs
that caused a change in the cache key still run with the most recent and
closest maching cache. Meaning that we in theory never need to pull
Bazel repositories or `node_modules` from scratch (unless we explicitly
want to purge the cache).

Same has been applied to `angular/angular` as well.
@devversion devversion force-pushed the build/add-circleci-fallback-caching branch from 826da05 to 7638c65 Compare March 27, 2019 13:46
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Mar 27, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 27, 2019
@ngbot
Copy link

ngbot bot commented Mar 27, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch-manager" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn jelbourn merged commit 434ef99 into angular:master Mar 27, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants