Skip to content

fix(datepicker): use narrower value for aria-haspopup #15666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2019

Conversation

crisbeto
Copy link
Member

Sets the value of aria-haspopup to dialog in order to indicate what kind of popup will be opened.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Mar 31, 2019
@crisbeto crisbeto requested a review from mmalerba as a code owner March 31, 2019 16:43
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 31, 2019
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Apr 1, 2019
@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@jelbourn
Copy link
Member

@crisbeto I can get this merged if you can rebase

Sets the value of `aria-haspopup` to `dialog` in order to indicate what kind of popup will be opened.
@crisbeto crisbeto force-pushed the datepicker-aria-haspopup branch from 146ed56 to 2fd32ca Compare May 14, 2019 16:18
@crisbeto
Copy link
Member Author

Rebased.

@jelbourn jelbourn merged commit 0c62798 into angular:master May 14, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
Sets the value of `aria-haspopup` to `dialog` in order to indicate what kind of popup will be opened.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants