Skip to content

cleanup(universal-app): various improvements #15679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2019
Merged

cleanup(universal-app): various improvements #15679

merged 1 commit into from
Apr 2, 2019

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Apr 1, 2019

  • Create a separate root component & module
  • Add styling to hide overlay so hover styles can be inspected
  • Give cdk-virtual-scroll-viewport non-zero height
  • Add support for cdk-experimental and material-experimental

@mmalerba mmalerba added pr: merge safe target: patch This PR is targeted for the next patch release labels Apr 1, 2019
@mmalerba mmalerba requested a review from jelbourn April 1, 2019 17:28
@mmalerba mmalerba requested a review from devversion as a code owner April 1, 2019 17:28
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 1, 2019
@mmalerba
cleanup(universal-app): various improvements
5bf4591 
- Create a separate root component & module
- Add styling to hide overlay so hover styles can be inspected
- Give cdk-virtual-scroll-viewport non-zero height
- Add support for cdk-experimental and material-experimental
devversion
devversion approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Apr 2, 2019
@mmalerba mmalerba merged commit 7402d02 into angular:master Apr 2, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmalerba @devversion @jelbourn @googlebot