-
Notifications
You must be signed in to change notification settings - Fork 6.8k
chore(e2e): switch to Sass theme instead of prebuilt #15690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/e2e-app/BUILD.bazel
Outdated
@@ -23,9 +24,18 @@ ng_module( | |||
"//src/material-examples:examples", | |||
"//src/cdk-experimental/dialog", | |||
"//src/cdk-experimental/scrolling", | |||
"//src/material-experimental", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity: Why add this here?
We should only add deps that are actively used right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops, split this out from a different PR and forgot to remove that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is in preparation for upcoming changes to the e2e app
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.