Skip to content

refactor: move version export to core entry-point #15700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2019
Merged

refactor: move version export to core entry-point #15700

merged 1 commit into from
Apr 16, 2019

Conversation

devversion
Copy link
Member

  • Moves the VERSION export to the the core secondary entry-point. This ensures that the V8 package schematics don't resolve the VERSION symbol to the incorrect @angular/material/typings module name.
  • Removes the unused and outdated material subpackages test case that has been replaced with a working one.
  • Ensures that the V8 material imports rule resolves the symbol from the imported identifier and not from the aliased one (minor cleanup; no effect as we resolve the identifer to the original symbol anyway; just slower)

Related to: angular/material.angular.io#590

@devversion devversion added the needs: discussion Further discussion with the team is needed before proceeding label Apr 3, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 3, 2019
@jelbourn
Copy link
Member

jelbourn commented Apr 5, 2019

This just needs a BREAKING CHANGE marker in the commit message

@devversion
Copy link
Member Author

What is the breaking change? There is no change in public API technically. Or do you just want a general note reflecting what has changed under the hood?

@jelbourn
Copy link
Member

jelbourn commented Apr 5, 2019

Nevermind, I forgot that all the core symbols are already re-exported through the root

jelbourn
jelbourn approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs rebase

@jelbourn jelbourn added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful pr: lgtm target: major This PR is targeted for the next major release and removed needs: discussion Further discussion with the team is needed before proceeding labels Apr 5, 2019
@devversion
refactor: move version export to core entry-point
9eab1fd 
* Moves the `VERSION` export to the the `core` secondary entry-point. This ensures that the V8 package schematics don't resolve the `VERSION` symbol to the incorrect `@angular/material/typings` module name.
* Removes the unused and outdated material subpackages test case that has been replaced with a working one.
* Ensures that the V8 material imports rule resolves the symbol from the imported identifier and not from the aliased one (minor cleanup; no effect as we resolve the identifer to the original symbol anyway; just slower)
@devversion devversion force-pushed the refactor/move-version-export-to-core-entry-point branch from 13c549f to 9eab1fd Compare April 5, 2019 21:32
@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Apr 5, 2019
@devversion
Copy link
Member Author

@jelbourn Ready. waited for CI to be green.

@devversion devversion marked this pull request as ready for review April 5, 2019 21:47
@jelbourn jelbourn merged commit 6bcb1da into angular:master Apr 16, 2019
@devversion devversion mentioned this pull request May 3, 2019
Merged
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@devversion @RudolfFrederiksen
refactor: move version export to core entry-point (angular#15700)
0fd91b0 
* Moves the `VERSION` export to the the `core` secondary entry-point. This ensures that the V8 package schematics don't resolve the `VERSION` symbol to the incorrect `@angular/material/typings` module name.
* Removes the unused and outdated material subpackages test case that has been replaced with a working one.
* Ensures that the V8 material imports rule resolves the symbol from the imported identifier and not from the aliased one (minor cleanup; no effect as we resolve the identifer to the original symbol anyway; just slower)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devversion @jelbourn @googlebot