Skip to content

feat(radio): support theme color on mat-radio-group #15741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 6, 2019

Adds support for setting the color of the entire mat-radio-group, rather than having to set it on each button individually.

Fixes #15701.

@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Apr 6, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 6, 2019
@crisbeto crisbeto force-pushed the 15701/radio-group-color branch from 4d45927 to 5c7d555 Compare April 6, 2019 09:43
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Apr 8, 2019
@ngbot
Copy link

ngbot bot commented Apr 8, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch-manager" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

Adds support for setting the color of the entire `mat-radio-group`, rather than having to set it on each button individually.

Fixes angular#15701.
@crisbeto crisbeto force-pushed the 15701/radio-group-color branch from 39ce35e to aac12c5 Compare April 29, 2019 20:16
@jelbourn jelbourn merged commit 6c03e2f into angular:master May 13, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
Adds support for setting the color of the entire `mat-radio-group`, rather than having to set it on each button individually.

Fixes angular#15701.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mat-radio-group mat-radio-button should support color attribut.
5 participants