Skip to content

refactor: remove mixin classes from public api #15743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 6, 2019

Removes the base classes that are being used to apply mixins from the public API. These classes can't really be consumed outside of Material and exposing them bloats up the public API.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 6, 2019
@crisbeto crisbeto force-pushed the mixin-classes-public-api branch 2 times, most recently from 7c70e24 to c3f6892 Compare April 6, 2019 12:40
@crisbeto crisbeto marked this pull request as ready for review April 6, 2019 12:52
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Apr 6, 2019
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Apr 6, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@crisbeto crisbeto force-pushed the mixin-classes-public-api branch from c3f6892 to 992c572 Compare April 20, 2019 18:54
Removes the base classes that are being used to apply mixins from the public API. These classes can't really be consumed outside of Material and exposing them bloats up the public API.
@mmalerba mmalerba force-pushed the mixin-classes-public-api branch from 992c572 to 0f492fb Compare April 25, 2019 16:14
@mmalerba mmalerba merged commit d1366ba into angular:master Apr 25, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
* refactor: remove mixin classes from public api

Removes the base classes that are being used to apply mixins from the public API. These classes can't really be consumed outside of Material and exposing them bloats up the public API.

* fix experimental checkbox
@LastDragon-ru
Copy link

These classes can't really be consumed outside of Material and exposing them bloats up the public API.

MatInputMixinBase was useful 😞

export class MatFormFieldControlWrapper<T = any> extends MatInputMixinBase implements ControlValueAccessor, MatFormFieldControl<T> { ... } 

@mmalerba
Copy link
Contributor

@LastDragon-ru the only logic in MatInputMixinBase actually comes from mixinErrorState which is still part of the public API: https://github.com/angular/components/blob/master/src/material/core/common-behaviors/error-state.ts#L38-L69

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants