Skip to content

chore(a11y): Allow FocusTrap to be extended #15770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kseamon
Copy link
Collaborator

@kseamon kseamon commented Apr 9, 2019

This will be used to allow tabbing from edit lenses to another table cell in popover edit.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 9, 2019
@kseamon kseamon force-pushed the focus-trap-overridable-behavior branch from 8faf1a8 to 8fe8a29 Compare April 9, 2019 20:06
This will be used to allow tabbing from edit lenses to another table cell in popover edit.
@kseamon kseamon force-pushed the focus-trap-overridable-behavior branch from 8fe8a29 to 135e4d6 Compare April 9, 2019 20:16
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Apr 9, 2019
@crisbeto crisbeto added pr: merge safe target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release and removed target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release labels Apr 9, 2019
@andrewseguin andrewseguin merged commit 48c70da into angular:master Apr 9, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants