Skip to content

chore: update to angular 8.0.0-rc.1 #15909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 28, 2019
Merged

chore: update to angular 8.0.0-rc.1 #15909

merged 10 commits into from
Apr 28, 2019

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba added the target: major This PR is targeted for the next major release label Apr 25, 2019
@mmalerba mmalerba requested review from IgorMinar and jelbourn April 25, 2019 23:52
@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Apr 25, 2019
@alexeagle alexeagle added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Apr 26, 2019
@mmalerba mmalerba force-pushed the rc branch 2 times, most recently from f433276 to 74228fc Compare April 26, 2019 21:04
@googlebot googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Apr 26, 2019
@mmalerba mmalerba added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Apr 26, 2019
@googlebot googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Apr 26, 2019
@angular angular deleted a comment from googlebot Apr 26, 2019
@angular angular deleted a comment from googlebot Apr 26, 2019
@angular angular deleted a comment from googlebot Apr 26, 2019
@angular angular deleted a comment from googlebot Apr 26, 2019
@angular angular deleted a comment from googlebot Apr 26, 2019
@mmalerba mmalerba added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Apr 26, 2019
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Apr 26, 2019
@angular angular deleted a comment from googlebot Apr 27, 2019
@angular angular deleted a comment from googlebot Apr 27, 2019
@mmalerba mmalerba changed the title chore: update to angular 8.0.0-rc.0 chore: update to angular 8.0.0-rc.1 Apr 28, 2019
@mmalerba mmalerba added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Apr 28, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@mmalerba mmalerba requested a review from devversion April 28, 2019 00:28
jelbourn
jelbourn approved these changes Apr 28, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Apr 28, 2019
@mmalerba mmalerba merged commit e02fa3a into angular:master Apr 28, 2019
devversion
devversion approved these changes Apr 28, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Especially the double theta and schematic stuff.

@mmalerba mmalerba mentioned this pull request Apr 30, 2019
Closed
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@mmalerba @RudolfFrederiksen
chore: update to angular 8.0.0-rc.1 (angular#15909)
1e38f43 
* chore: update to angular 8.0.0-rc.1

* build: use ts-api-guardian from npm

* update rules_nodejs

* update to rc.1

* updgrade ts-api-guardian

* update @Angular-devkit

* don't rename symbols that start with ɵɵ

* add @bazel/bazel to dev deps

* fix e2e deps

* fix schematic tests
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@IgorMinar IgorMinar Awaiting requested review from IgorMinar

Assignees

@IgorMinar IgorMinar

@jelbourn jelbourn

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mmalerba @googlebot @jelbourn @devversion @alexeagle @IgorMinar @alan-agius4