Skip to content

build: update bazel nodejs rules to v0.29.0 #16063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2019

Conversation

devversion
Copy link
Member

Updates the rules_nodejs repository to v0.29.0 which
comes with a few fixes and breaking changes such as
strict dependencies for NPM modules. This means we
need to adjust a few build files in order to be able to
update.

Updates the `rules_nodejs` repository to v0.29.0 which
comes with a few fixes and breaking changes such as
strict dependencies for NPM modules. This means we
need to update a few build files in order to be able to
update.
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels May 20, 2019
@devversion devversion requested a review from jelbourn as a code owner May 20, 2019 12:51
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 20, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels May 20, 2019
@mmalerba mmalerba merged commit 59fc0cb into angular:master May 20, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
Updates the `rules_nodejs` repository to v0.29.0 which
comes with a few fixes and breaking changes such as
strict dependencies for NPM modules. This means we
need to update a few build files in order to be able to
update.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants