Skip to content

fix(popover-edit): focus trap not being destroyed and potential leaks with takeUntil #16091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2019
Merged

fix(popover-edit): focus trap not being destroyed and potential leaks with takeUntil #16091

merged 1 commit into from
Jul 24, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto added pr: merge safe target: patch This PR is targeted for the next patch release labels May 22, 2019
@crisbeto crisbeto requested a review from andrewseguin as a code owner May 22, 2019 20:42
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 22, 2019
@crisbeto crisbeto added the P2 The issue is important to a large percentage of users, with a workaround label Jul 5, 2019
@crisbeto
fix(popover-edit): focus trap not being destroyed and potential leaks…
3502e05 
… with takeUntil

* Fixes the focus trap associated with a popover edit not being cleaned up.
* Fixes potential memory leaks in the way `takeUntil` was being used. See https://blog.angularindepth.com/rxjs-avoiding-takeuntil-leaks-fb5182d047ef.
@crisbeto crisbeto force-pushed the popover-edit-potential-leaks branch from e752d19 to 3502e05 Compare July 5, 2019 20:51
jelbourn
jelbourn approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 24, 2019
@jelbourn jelbourn merged commit 174bf40 into angular:master Jul 24, 2019
andrewseguin pushed a commit that referenced this pull request Jul 29, 2019
@crisbeto @andrewseguin
fix(popover-edit): focus trap not being destroyed and potential leaks…
06953ec 
… with takeUntil (#16091)

* Fixes the focus trap associated with a popover edit not being cleaned up.
* Fixes potential memory leaks in the way `takeUntil` was being used. See https://blog.angularindepth.com/rxjs-avoiding-takeuntil-leaks-fb5182d047ef.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@kseamon kseamon kseamon approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @kseamon @googlebot