-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat: improve speed by defaulting font-display #16093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Commit message should use the |
Actually tests are failing because the tests asserted that the links were inserted properly. |
Fixes outdated tests.
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
Along the same lines as angular/components#16093. Sets the `display` parameter when loading fonts for better control over how they're loaded.
Along the same lines as angular/components#16093. Sets the `display` parameter when loading fonts for better control over how they're loaded.
Done in #16363 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This adheres us to lighthouse recommendations around best practices for font loading.
https://scotch.io/bar-talk/google-fonts-now-supports-font-display
https://font-display.glitch.me/