Skip to content

feat: improve speed by defaulting font-display #16093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

StephenFluin
Copy link
Contributor

This adheres us to lighthouse recommendations around best practices for font loading.

https://scotch.io/bar-talk/google-fonts-now-supports-font-display
https://font-display.glitch.me/

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 22, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels May 22, 2019
@jelbourn
Copy link
Member

Commit message should use the perf tag and mention "schematic" in the name

@devversion
Copy link
Member

Actually tests are failing because the tests asserted that the links were inserted properly.

@devversion devversion removed the action: merge The PR is ready for merge by the caretaker label May 22, 2019
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels May 23, 2019
crisbeto added a commit to crisbeto/material.angular.io that referenced this pull request May 28, 2019
Along the same lines as angular/components#16093. Sets the `display` parameter when loading fonts for better control over how they're loaded.
jelbourn pushed a commit to angular/material.angular.io that referenced this pull request May 28, 2019
Along the same lines as angular/components#16093. Sets the `display` parameter when loading fonts for better control over how they're loaded.
@jelbourn
Copy link
Member

Done in #16363

@jelbourn jelbourn closed this Jun 24, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants