fix(material/menu): account for menu padding different from the default #16169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P4
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
16167/custom-menu-padding
branch
from
18779fd to
3a495f9
Compare
crisbeto
force-pushed
the
16167/custom-menu-padding
branch
from
3a495f9 to
34cd5dd
Compare
andrewseguin
added
needs rebase
and removed
cla: yes
crisbeto
force-pushed
the
16167/custom-menu-padding
branch
from
34cd5dd to
cef9436
Compare
crisbeto
changed the title
crisbeto
force-pushed
the
16167/custom-menu-padding
branch
8 times, most recently
from
77e98e8 to
6965f95
Compare
Currently we use the hardcoded value of the menu padding to offset the panel so the two menu triggers align. Since the value is in TS, the logic breaks down if the user has set their own padding. These changes add some logic to compute the padding the first time a sub-menu is opened. Fixes angular#16167.
crisbeto
force-pushed
the
16167/custom-menu-padding
branch
from
6965f95 to
153f3ec
Compare
crisbeto
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use the hardcoded value of the menu padding to offset the panel so the two menu triggers align. Since the value is in TS, the logic breaks down if the user has set their own padding. These changes add some logic to compute the padding the first time a sub-menu is opened.
Fixes #16167.