fix(progress-spinner): non-default diameter indeterminate animation not working inside Shadow DOM #16177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
16172/spinner-shadow-dom
branch
2 times, most recently
from
fab4566 to
9e8a2f7
Compare
|
@crisbeto Can you rebase when you have a chance? |
…ot working inside Shadow DOM Fixes animating a progress spinner with a non-default diameter in indeterminate mode not working if the element is inside of a shadow root. The issue is that we always add the `style` tag with the animation to the `document.head` which doesn't pierce through the Shadow DOM. Fixes angular#16172.
crisbeto
force-pushed
the
16172/spinner-shadow-dom
branch
from
9e8a2f7 to
d05d9ca
Compare
|
Rebased. |
josephperrott
pushed a commit
that referenced
this pull request
Jun 10, 2019
…ot working inside Shadow DOM (#16177)
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
…ot working inside Shadow DOM (angular#16177)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes animating a progress spinner with a non-default diameter in indeterminate mode not working if the element is inside of a shadow root. The issue is that we always add the
styletag with the animation to thedocument.headwhich doesn't pierce through the Shadow DOM.Also adds a some more test coverage for the
styletag insertion logic.Fixes #16172.