Skip to content

chore: enable noFallthroughCasesInSwitch in the project's tsconfigs #16282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2019
Merged

chore: enable noFallthroughCasesInSwitch in the project's tsconfigs #16282

merged 1 commit into from
Jun 12, 2019

Conversation

josephperrott
Copy link
Member

Blocked by #16281 as it is the removal of the only fallthrough usage in our library.

@josephperrott josephperrott added blocked This issue is blocked by some external factor, such as a prerequisite PR pr: merge safe target: patch This PR is targeted for the next patch release labels Jun 12, 2019
@josephperrott josephperrott requested a review from jelbourn June 12, 2019 21:16
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 12, 2019
jelbourn
jelbourn approved these changes Jun 12, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott force-pushed the prevent-fallthroughs branch from 2e95503 to 1e3b0df Compare June 12, 2019 21:44
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Jun 12, 2019
@mmalerba mmalerba merged commit 933d44c into angular:master Jun 12, 2019
@josephperrott josephperrott deleted the prevent-fallthroughs branch June 13, 2019 16:50
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@josephperrott @RudolfFrederiksen
chore: enable noFallthroughCasesInSwitch in the project's tsconfigs (a…
59d924a 
…ngular#16282)
andrewseguin pushed a commit that referenced this pull request Jul 2, 2019
@josephperrott @andrewseguin
chore: enable noFallthroughCasesInSwitch in the project's tsconfigs (#…
3697aa9 
…16282)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josephperrott @jelbourn @googlebot @mmalerba