-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Fix wrong autocomplete-plain-input example (fixes #16327) #16329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is auto-generated so your changes will be lost next time we create it. What issue is it trying to solve?
@crisbeto I see... I was trying to fix #16327. The example for "Autocomplete on a custom input element" is broken in the documentation, I opened the console and saw the error "Could not find example: autocomplete-plain-input". I think it's because the example is declared as "plain-input-autocomplete" in the EXAMPLE_COMPONENTS object, while it is referred to as "autocomplete-plain-input" in the documentation markdown file https://github.com/angular/components/blob/master/src/material/autocomplete/autocomplete.md#L99 <!-- example(autocomplete-plain-input) --> I don't know which one is wrongly named, I can fix the reference instead and submit a new pull request. |
If the reference is wrong, it should be fixed in the Markdown file. Also you can push your change to the same PR. |
Done, thanks for the feedback |
Sorry, I just double-checked and it looks like we have to generate the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fix for #16327