build: fix snapshot local browsers cronjob test #16362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `snapshot_tests_local_browsers` job currently seems to fail because in order to run the setup snapshots script, we already need to have the `node_modules` installed. This means that we need to run Yarn twice for the cronjob. Though this shouldn't have any performance implications because we recently updated Yarn to a version that is able to properly cache/restore the `node_modules`.
googlebot
added
the
cla: yes
Remove test to ensure cronjob works
devversion
added
pr: merge safe
target: patch
josephperrott
added
pr: lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Jul 2, 2019
The `snapshot_tests_local_browsers` job currently seems to fail because in order to run the setup snapshots script, we already need to have the `node_modules` installed. This means that we need to run Yarn twice for the cronjob. Though this shouldn't have any performance implications because we recently updated Yarn to a version that is able to properly cache/restore the `node_modules`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
snapshot_tests_local_browsersjob currently seemsto fail because in order to run the setup snapshots script,
we already need to have the
node_modulesinstalled. Thismeans that we need to run Yarn twice for the cronjob. Though
this shouldn't have any performance implications because
we recently updated Yarn to a version that is able to
properly cache/restore the
node_modules.