Skip to content

feat(schematics): add font-display query #16363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2019
Merged

feat(schematics): add font-display query #16363

merged 1 commit into from
Jun 24, 2019

Conversation

puku0x
Copy link
Contributor

@puku0x puku0x commented Jun 23, 2019

Since Google Fonts supports font-display now, why don't we add it to schematics?
https://developers.google.com/fonts/docs/getting_started#use_font-display

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 23, 2019
@lpl14
Copy link

lpl14 commented Jun 23, 2019

duplicate of #16093

@devversion
Copy link
Member

devversion commented Jun 23, 2019 •
edited
Loading

@jelbourn I tried to help Stephen with #16093 but it already got stale since we didn't merge it. Not sure if we should try this one or try to move forward with Stephen's PR.

devversion
devversion reviewed Jun 23, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise.

jelbourn
jelbourn approved these changes Jun 24, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 24, 2019
@jelbourn jelbourn merged commit 43a01e9 into angular:master Jun 24, 2019
@jelbourn jelbourn mentioned this pull request Jun 24, 2019
Closed
@puku0x puku0x deleted the schematics-ng-add-fonts-diplay-swap branch July 3, 2019 00:57
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion left review comments

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@puku0x @lpl14 @devversion @jelbourn @googlebot