Skip to content

build: run CI unit tests using bazel #16379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2019
Merged

build: run CI unit tests using bazel #16379

merged 1 commit into from
Jun 26, 2019

Conversation

josephperrott
Copy link
Member

No description provided.

@josephperrott josephperrott added pr: merge safe target: patch This PR is targeted for the next patch release labels Jun 25, 2019
@josephperrott josephperrott requested a review from devversion June 25, 2019 16:31
@josephperrott josephperrott requested a review from jelbourn as a code owner June 25, 2019 16:31
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 25, 2019
jelbourn
jelbourn reviewed Jun 25, 2019
View reviewed changes
devversion
devversion approved these changes Jun 25, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from Jeremy's comment. LGTM

@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Jun 25, 2019
jelbourn
jelbourn approved these changes Jun 25, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jun 26, 2019
@josephperrott
Copy link
Member Author

Caretaker Note: When this goes in we will need to update our required statuses for github to include bazel_build instead of bazel_build_test

@andrewseguin andrewseguin merged commit 2bf0612 into angular:master Jun 26, 2019
andrewseguin pushed a commit that referenced this pull request Jul 2, 2019
@josephperrott @andrewseguin
build: run CI unit tests using bazel (#16379)
7f133af
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@josephperrott @jelbourn @devversion @googlebot @andrewseguin