Skip to content

fix: table sort for array of string and numbers #16499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: table sort for array of string and numbers #16499

wants to merge 2 commits into from

Conversation

jsCommander
Copy link

MatSort can't sort mixed array (string and numbers) correctly. I add
checking for compare number with string and now all numbers come first.

issue: 16303

MatSort can't sort mixed array (string and numbers) correctly. I add
checking for compare number with string and now all numbers come first.

issue: 16303
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Jul 11, 2019
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@andrewseguin
Copy link
Contributor

Can you add some tests to make sure this behaves as expected?

@andrewseguin
Copy link
Contributor

I opened a PR #18767 with a new test suite for the data source, once it's in you can add some tests for your code:

    it('should be able to correctly sort strings with numbers', () => {
      testSortWithValues(['0', '1', 'lemons', 'strawberries']);
    });

    it('should be able to correctly sort array with mix of strings and numbers', () => {
      testSortWithValues([0, 1, 'lemons', 'strawberries']);
    });

@jsCommander
Copy link
Author

jsCommander commented Apr 18, 2020

@andrewseguin, hi, thanks for reviewing my pull request.
Unfortunately, I deleted my pull request repository by mistake and i don't known how to fix it.
So I created new pull request #19109 with tests.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants