-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix: table sort for array of string and numbers #16499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MatSort can't sort mixed array (string and numbers) correctly. I add checking for compare number with string and now all numbers come first. issue: 16303
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Can you add some tests to make sure this behaves as expected? |
I opened a PR #18767 with a new test suite for the data source, once it's in you can add some tests for your code:
|
@andrewseguin, hi, thanks for reviewing my pull request. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
MatSort can't sort mixed array (string and numbers) correctly. I add
checking for compare number with string and now all numbers come first.
issue: 16303