Revert "fix(menu): keyboard controls not respecting DOM order when it… #16502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ems are added at a later point (angular#11720)" This reverts commit 49e8c59.
jelbourn
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
andrewseguin
added
action: merge
andrewseguin
approved these changes
Jul 11, 2019
|
@jelbourn did this not need to be merged or was it decided not to revert it? |
|
@jelbourn still waiting for merge... Right now it seems like dynamic menus creation is no longer possible. Or is there another way? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ems are added at a later point (#11720)"
This reverts commit 49e8c59.
Reverting this because it breaks interactions on menu items (like hover) when using
MatMenuContent