build: add API goldens for portal #16655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
added
P2
devversion
reviewed
Jul 31, 2019
Adds API goldens for the portal package and fixes some compilation errors that showed up when I was trying to generate it.
|
Done. |
jelbourn
added
pr: lgtm
action: merge
devversion
approved these changes
Jul 31, 2019
|
This is not actually merge safe and looks like it may have broken some apps, therefore reverting |
mmalerba
pushed a commit
that referenced
this pull request
Aug 14, 2019
Adds API goldens for the portal package and fixes some compilation errors that showed up when I was trying to generate it. (cherry picked from commit 8b5afcc)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds API goldens for the portal package and fixes some compilation errors that showed up when I was trying to generate it.