Skip to content

feat(dialog): expose current dialog state #16691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2019
Merged

feat(dialog): expose current dialog state #16691

merged 1 commit into from
Aug 27, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 5, 2019

Exposes whether the dialog is currently open, closed or closing. This is useful when writing components around our dialog.

Fixes #16636.

@crisbeto
feat(dialog): expose current dialog state
3f56d97 
Exposes whether the dialog is currently open, closed or closing. This is useful when writing components around our dialog.

Fixes angular#16636.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release labels Aug 5, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner August 5, 2019 14:42
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 5, 2019
jelbourn
jelbourn approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 14, 2019
@jelbourn jelbourn merged commit 3f0268f into angular:master Aug 27, 2019
mmalerba pushed a commit to mmalerba/components that referenced this pull request Aug 27, 2019
@crisbeto @mmalerba
feat(dialog): expose current dialog state (angular#16691)
1a423f6 
Exposes whether the dialog is currently open, closed or closing. This is useful when writing components around our dialog.

Fixes angular#16636.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detect if DialogRef close has been called
3 participants
@crisbeto @jelbourn @googlebot