Skip to content

feat(material-experimental): add Clipboard service and directive. #16704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 13, 2019
Merged

feat(material-experimental): add Clipboard service and directive. #16704

merged 7 commits into from
Aug 13, 2019

Conversation

xkxx
Copy link
Collaborator

@xkxx xkxx commented Aug 6, 2019

As discussed with @jelbourn offline, this PR adds utilities for working with the clipboard:

  • Clipboard: a service that copies content into user's clipboard (must be called as part of a click handler)
  • [copyToClipboard]: a directive that adds the copy to clipboard behavior to an interactive element.

@xkxx xkxx requested a review from jelbourn as a code owner August 6, 2019 20:17
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 6, 2019
@jelbourn jelbourn requested a review from crisbeto August 9, 2019 23:11
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Aug 13, 2019
@jelbourn jelbourn merged commit a8e0b48 into angular:master Aug 13, 2019
mmalerba pushed a commit that referenced this pull request Aug 14, 2019
@benneq
Copy link

benneq commented Aug 14, 2019

Isn't this part of @angular/cdk-experimental 8.1.3?
My downloaded version from npm doesn't include ClipboardModule 😢

package.json from node_modules/@angular/cdk-experimental says "version": "8.1.3"

@mmalerba
Copy link
Contributor

Ah, it looks like its missing a tsconfig-build.json, so even though the code is there it didn't get copied into the release

@mmalerba
Copy link
Contributor

I've sent a fix PR: #16785

@xkxx
Copy link
Collaborator Author

xkxx commented Aug 15, 2019

Oops, I didn't even realize I needed to do that. Thanks @mmalerba!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants