fix(build): binary execution on windows #1675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currenlty the `execNodeTask` helper function resolves the binary from the `package.json` and spawns a new process of it. Specifically on Windows this will break, because the Windows Shell does not know how to run the given files (from the Shebang or PATHEXT) Since those binaries are always node binaries we could manually run the node interpreter and run the given JS file as an argument. Closes angular#1129
googlebot
added
the
cla: yes
|
R: @hansl |
|
LGTM. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically on Windows this will break, because the Windows Shell does not know how to run the given files (from the Shebang or PATHEXT)
Since those binaries are always node binaries we could manually run the node interpreter and run the given JS file as an argument.
task_helpers.tsfile as well)execNodeTaskfunction works on Windows as well (fixesgulp e2eandgulp build:releaseon windows)Closes #1129