build: fix bazel not available if cache could not be restored #16764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `setup_bazel_binary` script always runs before the node modules are installed. This means that the the global bazel binary cannot be set up as the `@bazel/bazel` package is not installed yet. Due to CircleCI's caching (and fallback caching) we currently have a lot of cache hits that prevented this issue from showing up (until https://circleci.com/gh/angular/components/70351)
googlebot
added
the
cla: yes
devversion
added
pr: merge safe
target: patch
jelbourn
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
mmalerba
pushed a commit
that referenced
this pull request
Aug 14, 2019
Currently the `setup_bazel_binary` script always runs before the node modules are installed. This means that the the global bazel binary cannot be set up as the `@bazel/bazel` package is not installed yet. Due to CircleCI's caching (and fallback caching) we currently have a lot of cache hits that prevented this issue from showing up (until https://circleci.com/gh/angular/components/70351) (cherry picked from commit 417adf8)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
setup_bazel_binaryscript always runs beforethe node modules are installed. This means that the the
global bazel binary cannot be set up as the
@bazel/bazelpackage is not installed yet.
Due to CircleCI's caching (and fallback caching) we currently
have a lot of cache hits that prevented this issue from showing
up (until https://circleci.com/gh/angular/components/70351)