Skip to content

feat(material-experimental/mdc-button): use MDC classnames in CSS #16768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

andrewseguin
Copy link
Contributor

Alternatively we can use the mat-mdc- prefix for the component names but that would be more verbose without any additional gain

@andrewseguin andrewseguin added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe target: patch This PR is targeted for the next patch release labels Aug 13, 2019
@andrewseguin andrewseguin requested a review from mmalerba August 13, 2019 19:51
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 13, 2019
@mmalerba
Copy link
Contributor

The one worry with this is that we could affect MDC components on the page that are used outside of Angular. I'm not sure how much of a real concern this is... I could see it maybe being an issue if they were using Angular Elements or something

@andrewseguin
Copy link
Contributor Author

I didn't consider that. I'll rework this after #16767 is in to use our custom classnames

@andrewseguin
Copy link
Contributor Author

Changed the code to use the mat-mdc selectors to avoid conflicting with any existing MDC buttons on the page apart from Angular Material

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 14, 2019
@andrewseguin andrewseguin merged commit ee01134 into angular:master Aug 14, 2019
andrewseguin added a commit that referenced this pull request Aug 26, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants