Skip to content

fix(sidenav): avoid CSS class name conflict #16798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2019

Conversation

crisbeto
Copy link
Member

Currently both the drawer and drawer container use a class called mat-drawer-opened which can cause confusion. These changes rename the class on the container.

Currently both the drawer and drawer container use a class called `mat-drawer-opened` which can cause confusion. These changes rename the class on the container.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Aug 16, 2019
@crisbeto crisbeto requested a review from mmalerba as a code owner August 16, 2019 17:15
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 16, 2019
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 16, 2019
@mmalerba mmalerba merged commit 1de1b98 into angular:master Aug 16, 2019
andrewseguin pushed a commit that referenced this pull request Aug 26, 2019
Currently both the drawer and drawer container use a class called `mat-drawer-opened` which can cause confusion. These changes rename the class on the container.

(cherry picked from commit 1de1b98)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants