Skip to content

refactor: debugElement.query is nullable #16917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 30, 2019

Conversation

lacolaco
Copy link
Contributor

This is a necessary step to pass CI for angular/angular#32365

DebugElement.query can return null in fact but its type definition doesn't include it.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 30, 2019
@mmalerba
Copy link
Contributor

Looks like lint check is failing because some lines are too long now, otherwise LGTM

@lacolaco
Copy link
Contributor Author

@mmalerba How can I format those files? yarn format didn't work.

@mmalerba
Copy link
Contributor

I don't think we ever fully switched to using clang format because we were afraid of causing rebase issues with every open PR. Sadly, the best way is probably just to fix them by hand

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker pr: merge safe target: patch This PR is targeted for the next patch release labels Aug 30, 2019
@jelbourn jelbourn merged commit e14df64 into angular:master Aug 30, 2019
@lacolaco lacolaco deleted the debugelement-query-is-nullable branch August 31, 2019 00:20
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants