Skip to content

build: format mdc-slider build file imports #16919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

When the mdc-slider change landed, the PR was not rebased on top
of the latest changes in master. Meaning that the buildifier alphabetical
sorting rule was not enabled and the build file now fails the sort rule in
master.

When the mdc-slider change landed, the PR was not rebased on top
of the latest changes in `master`. Meaning that the buildifier alphabetical
sorting rule was not enabled and the build file now fails the sort rule in
`master`.
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Aug 30, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 30, 2019
@devversion
Copy link
Member Author

Test failures are unrelated to this PR. They will be fixed with #16918

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 181ce59 into angular:master Aug 30, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants