fix(select): fix panel close animation #1696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
changed the title
hansl
reviewed
Nov 2, 2016
| @@ -58,10 +58,10 @@ export const transformPanel: AnimationEntryMetadata = trigger('transformPanel', | |||
| width: '100%', | |||
| transform: `translate3d(0, 0, 0) scaleY(0)` | |||
| }), | |||
| animate(`150ms cubic-bezier(0.55, 0, 0.55, 0.2)`) | |||
| animate(`150ms cubic-bezier(0.25, 0.8, 0.25, 1)`) | |||
There was a problem hiding this comment.
Where did you get those values? Seems like a more aggressive ease-out.
There was a problem hiding this comment.
These are the Material 1 values for the ease out animation. I accidentally used the Material 1 values for the ease in animation here (copy-paste error).
| @@ -158,7 +159,6 @@ export class MdSelect implements AfterContentInit, OnDestroy { | |||
| this._focusCorrectOption(); | |||
| this.onOpen.emit(); | |||
| } else { | |||
| this._focusHost(); | |||
There was a problem hiding this comment.
Please change the comment above to reflect the code.
| @@ -108,6 +108,7 @@ export class MdSelect implements AfterContentInit, OnDestroy { | |||
| /** Closes the overlay panel. */ | |||
| close(): void { | |||
| this._panelOpen = false; | |||
| this._focusHost(); | |||
There was a problem hiding this comment.
Please change the comment above to reflect the code.
| @@ -16,6 +16,7 @@ md-select { | |||
| height: $md-select-trigger-height; | |||
| min-width: $md-select-trigger-min-width; | |||
| cursor: pointer; | |||
| user-select: none; | |||
kara
force-pushed
the
select-animations
branch
from
1b7ab1e to
65f0c58
Compare
kara
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks to make the menu close animation smoother.
r: @hansl