Skip to content

feat(material-experimental/button): anchor disabled state #16962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andrewseguin
Copy link
Contributor

Manually style buttons as disabled:

  • MDC does not apply disabled style to anchor buttons
  • MDC does not apply the right styles for the dark theme

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 3, 2019
@andrewseguin andrewseguin force-pushed the mdc-button-anchor-disabled branch from dd4a606 to 06cbe30 Compare September 3, 2019 17:52
@andrewseguin andrewseguin force-pushed the mdc-button-anchor-disabled branch from 06cbe30 to de99472 Compare September 3, 2019 17:52
@andrewseguin andrewseguin force-pushed the mdc-button-anchor-disabled branch from 38ca279 to b21c8c1 Compare September 4, 2019 18:29
@andrewseguin
Copy link
Contributor Author

TODO's were added for the cases where we need to discuss with the MDC team (as well as added to our next meeting notes)

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Sep 4, 2019
@andrewseguin andrewseguin merged commit 7ad684c into angular:master Sep 5, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants