build: do not include material prebuilt theme twice in legacy tests #16966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently we include the Angular Material prebuilt theme twice in the legacy Karma tests. This is because we also generate a second folder called `esm5` in the package output (for later use in the release composing step). This folder also contains the prebuilt themes as a side-effect of copying the assets for esm5 inlining/bundling. In any case, we should not import the theme using a glob, but rather use an explicit path (similar to how we do it for the mdc theme).
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
josephperrott
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just something I noticed while investigating the MDC slider test failures on Edge BS..
Apparently we include the Angular Material prebuilt theme twice in the
legacy Karma tests. This is because we also generate a second folder
called
esm5in the package output (for later use in the releasecomposing step). This folder also contains the prebuilt themes as
a side-effect of copying the assets for esm5 inlining/bundling.
In any case, we should not import the theme using a glob, but rather
use an explicit path (similar to how we do it for the mdc theme).