fix(progress-spinner): animation node inserted into wrong style root when using ngIf with ShadowDom encapsulation #16982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
googlebot
added
the
cla: yes
jelbourn
approved these changes
Sep 5, 2019
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
…when using ngIf with ShadowDom encapsulation If the progress spinner is inside the shadow DOM, we attach the `style` tag with the animation to the shadow root, however since we do the insertion inside the constructor, the spinner might not have been moved into the shadow root yet. These changes move the logic into `ngOnInit` which fires late enough for the node to be in the correct place.
crisbeto
force-pushed
the
progress-spinner-insertion-order
branch
from
7825ca9 to
84267d0
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the progress spinner is inside the shadow DOM, we attach the
styletag with the animation to the shadow root, however since we do the insertion inside the constructor, the spinner might not have been moved into the shadow root yet. These changes move the logic intongOnInitwhich fires late enough for the node to be in the correct place.