Skip to content

test: dialog harness tests leak open dialogs #16983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2019
Merged

test: dialog harness tests leak open dialogs #16983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/material-experimental/mdc-dialog/harness/dialog-harness.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,14 @@ describe('MatDialogHarness', () => {

/** Shared tests to run on both the original and MDC-based radio-button's. */
function runTests() {
afterEach(() => {
// Close all dialogs upon test exit. This is necessary because the "MatDialog"
// service is not destroyed in TestBed automatically, and it could mean that
// dialogs are left in the DOM.
fixture.componentInstance.dialog.closeAll();
fixture.detectChanges();
});

it('should load harness for dialog', async () => {
fixture.componentInstance.open();
const dialogs = await loader.getAllHarnesses(dialogHarness);
Expand Down