Skip to content

refactor: move force-stabilize from TestElement to ComponentHarness #17149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2019
Merged

refactor: move force-stabilize from TestElement to ComponentHarness #17149

merged 2 commits into from
Oct 1, 2019

Conversation

mmalerba
Copy link
Contributor

Currently the forceStabilize method lives on TestElement. This is
not the most ergonomic place, given its intended use. This PR moves it
to the ComponentHarness base class so that subclasses can simply call
await this.forceStabilize()

@mmalerba
refactor: move force-stabilize from TestElement to ComponentHarness
713b52a 
Currently the `forceStabilize` method lives on `TestElement`. This is
not the most ergonomic place, given its intended use. This PR moves it
to the `ComponentHarness` base class so that subclasses can simply call
`await this.forceStabilize()`
@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Sep 19, 2019
@mmalerba mmalerba added this to the 9.0.0 milestone Sep 19, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 19, 2019
@mmalerba
Copy link
Contributor Author

related to #16676

crisbeto
crisbeto approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba requested a review from a team as a code owner September 19, 2019 20:06
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 19, 2019
@mmalerba mmalerba added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Sep 27, 2019
@mmalerba
Copy link
Contributor Author

CARETAKER NOTE: requires corresponding changes to be made in CatalystHarnessEnvironment

@mmalerba mmalerba added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful and removed P2 The issue is important to a large percentage of users, with a workaround labels Oct 1, 2019
@mmalerba mmalerba merged commit 6458c3b into angular:master Oct 1, 2019
@mmalerba mmalerba deleted the force-stab branch October 1, 2019 18:32
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: major This PR is targeted for the next major release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mmalerba @crisbeto @devversion @jelbourn @googlebot