Skip to content

fix(datepicker): add scope to calendar headers #17163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2019
Merged

fix(datepicker): add scope to calendar headers #17163

merged 1 commit into from
Sep 27, 2019

Conversation

crisbeto
Copy link
Member

Sets a scope to the relevant th elements in the calendar header for improved accessibility.

Fixes #17038.

@crisbeto
fix(datepicker): add scope to calendar headers
73343ad 
Sets a `scope` to the relevant `th` elements in the calendar header for improved accessibility.

Fixes angular#17038.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Sep 21, 2019
@crisbeto crisbeto requested a review from mmalerba as a code owner September 21, 2019 11:46
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 21, 2019
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 23, 2019
@andrewseguin andrewseguin merged commit b0c69dd into angular:master Sep 27, 2019
andrewseguin pushed a commit that referenced this pull request Sep 30, 2019
@crisbeto @andrewseguin
fix(datepicker): add scope to calendar headers (#17163)
cf244ff 
Sets a `scope` to the relevant `th` elements in the calendar header for improved accessibility.

Fixes #17038.

(cherry picked from commit b0c69dd)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add scope attribute to headers in DatePicker for improved accessibility
4 participants
@crisbeto @mmalerba @googlebot @andrewseguin