Skip to content

fix(material-experimental/mdc-slider): not usable in high contrast mode #17164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2019
Merged

fix(material-experimental/mdc-slider): not usable in high contrast mode #17164

merged 1 commit into from
Sep 27, 2019

Conversation

crisbeto
Copy link
Member

Fixes the MDC slider track not being visible in high contrast mode and the thumb label just floating on top of the slider.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe target: patch This PR is targeted for the next patch release labels Sep 21, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 21, 2019
devversion
devversion approved these changes Sep 21, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@crisbeto
fix(material-experimental/mdc-slider): not usable in high contrast mode
eb2adbb 
Fixes the MDC slider track not being visible in high contrast mode and the thumb label just floating on top of the slider.
@crisbeto crisbeto force-pushed the mdc-slider-high-contrast branch from df97d1a to eb2adbb Compare September 21, 2019 16:28
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 21, 2019
@andrewseguin andrewseguin merged commit da14f16 into angular:master Sep 27, 2019
andrewseguin pushed a commit that referenced this pull request Sep 30, 2019
@crisbeto @andrewseguin
fix(material-experimental/mdc-slider): not usable in high contrast mo…
73a233d 
…de (#17164)

Fixes the MDC slider track not being visible in high contrast mode and the thumb label just floating on top of the slider.

(cherry picked from commit da14f16)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @devversion @googlebot @andrewseguin