Skip to content

refactor: clean up deprecated uses of combineLatest #17168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

crisbeto
Copy link
Member

The signature of combineLatest that uses individual parameters has been deprecated. These changes switch to the new recommended way which passes in the observables as an array.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Sep 22, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 22, 2019
Copy link
Collaborator

@kseamon kseamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 23, 2019
The signature of `combineLatest` that uses individual parameters has been deprecated. These changes switch to the new recommended way which passes in the observables as an array.
@mmalerba mmalerba force-pushed the deprecated-combinelatest branch from e1577a0 to 8f91f19 Compare October 3, 2019 18:30
@mmalerba mmalerba merged commit 3961544 into angular:master Oct 3, 2019
mmalerba pushed a commit that referenced this pull request Oct 8, 2019
The signature of `combineLatest` that uses individual parameters has been deprecated. These changes switch to the new recommended way which passes in the observables as an array.

(cherry picked from commit 3961544)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants