build: remove ng_package entry-point workaround #17171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
We recently had to switch all `ts_library` entry points to use `ng_module` because the `ng_package` rule did not properly handle `ts_library` targets as entry-points. angular/angular@217db9b fixed this issue upstream and we can now use `ts_library` instead of `ng_module` for vanilla TS entry-points.
devversion
force-pushed
the
build/remove-entry-point-ng-package-workaround
branch
from
6987b44 to
8e9b500
Compare
devversion
requested review from
andrewseguin,
crisbeto,
jelbourn and
mmalerba
as code owners
devversion
added
pr: merge safe
target: patch
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently had to switch all
ts_libraryentrypoints to use
ng_modulebecause theng_packagerule did not properly handle
ts_librarytargetsas entry-points.
angular/angular@217db9b fixed this issue upstream and we can
now use
ts_libraryinstead ofng_modulefor vanilla TS entry-points.