Skip to content

fix(datepicker): year not formatted in multi-year view button #17202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

crisbeto
Copy link
Member

Fixes the years that are rendered in the calendar's perioud button not being formatted through the date adapter in the multi-view. This can result in an incorrect value being displayed in some locales.

Fixes #17187.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Sep 25, 2019
@crisbeto crisbeto requested a review from mmalerba as a code owner September 25, 2019 18:04
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 25, 2019
Fixes the years that are rendered in the calendar's perioud button not being formatted through the date adapter in the multi-view. This can result in an incorrect value being displayed in some locales.

Fixes angular#17187.
@crisbeto crisbeto force-pushed the 17187/datepicker-button-year-format branch from 2285cfa to 7c9415e Compare September 29, 2019 15:41
@crisbeto
Copy link
Member Author

Reworked based on the discussion @mmalerba.

@mmalerba mmalerba added i18n This issue is related to internationalization pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 30, 2019
@mmalerba mmalerba merged commit ae28fce into angular:master Oct 3, 2019
mmalerba pushed a commit that referenced this pull request Oct 8, 2019
Fixes the years that are rendered in the calendar's perioud button not being formatted through the date adapter in the multi-view. This can result in an incorrect value being displayed in some locales.

Fixes #17187.

(cherry picked from commit ae28fce)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement i18n This issue is related to internationalization P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MatCalendarHeader at version8 periodButtonText doesn't display TH local format
3 participants