Skip to content

chore(testing): fix compilation for TS3.6. #17218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2019
Merged

chore(testing): fix compilation for TS3.6. #17218

merged 1 commit into from
Oct 1, 2019

Conversation

mprobst
Copy link
Contributor

@mprobst mprobst commented Sep 27, 2019

TS3.6 no longer includes the initUIEvent method.

@mprobst
chore(testing): fix compilation for TS3.6.
867e0b4 
TS3.6 no longer includes the initUIEvent method.
@mprobst mprobst requested a review from devversion September 27, 2019 13:09
@mprobst mprobst requested a review from mmalerba as a code owner September 27, 2019 13:09
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 27, 2019
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 27, 2019
@mmalerba mmalerba added this to the 9.0.0 milestone Sep 27, 2019
@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Sep 27, 2019
@mmalerba mmalerba added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful and removed P2 The issue is important to a large percentage of users, with a workaround labels Oct 1, 2019
@mmalerba mmalerba merged commit a306e93 into master Oct 1, 2019
mmalerba pushed a commit that referenced this pull request Oct 8, 2019
@mprobst @mmalerba
chore(testing): fix compilation for TS3.6. (#17218)
28c2345 
TS3.6 no longer includes the initUIEvent method.

(cherry picked from commit a306e93)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mprobst @devversion @mmalerba @googlebot